gh-103092: Isolate _collections#103093
Merged
kumaraditya303 merged 22 commits intopython:mainfrom Apr 12, 2023
Merged
Conversation
25 tasks
kumaraditya303
approved these changes
Apr 9, 2023
Contributor
kumaraditya303
left a comment
There was a problem hiding this comment.
LGTM, I finished the remaining bits.
Contributor
|
Now it crashes in the dict watcher deallocation, cc @carljm |
Contributor
Author
This comment was marked as outdated.
This comment was marked as outdated.
kumaraditya303
approved these changes
Apr 10, 2023
Contributor
Author
|
BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks on |
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0dcfcef 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0381b45 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Contributor
Author
|
Good find! No ref.leaks locally over here. |
Contributor
Author
|
Good job! |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.